2010 frog design criticisms

From CSSEMediaWiki
(Difference between revisions)
Jump to: navigation, search
 
Line 5: Line 5:
 
3. Move Interdace should be Method
 
3. Move Interdace should be Method
  
4. saute in wine, export to xml {frog knows about this?}
+
4. saute in wine, export to xml {frog knows about this? i.e. seperation of concerns, model the real world.}
  
 
5. singleton biologist broken.
 
5. singleton biologist broken.
Line 13: Line 13:
 
7. Adult frog knows who ate it.
 
7. Adult frog knows who ate it.
  
8. Toad is a subclass of Frog
+
8. Toad is a subclass of Frog. (Inheritance for implementation)
  
 
9. Encapsulation Violation
 
9. Encapsulation Violation
 +
 +
10.

Latest revision as of 05:00, 15 July 2010

1. Becomes Issue(Egg-Tad-Frog)

2. Tadpole Tailtype i.e. Swim method. (Switch stament smell. Type Safety issues. Maybe Change to strategy pattern)

3. Move Interdace should be Method

4. saute in wine, export to xml {frog knows about this? i.e. seperation of concerns, model the real world.}

5. singleton biologist broken.

6. Frogbrain? (why doe it have eggs)

7. Adult frog knows who ate it.

8. Toad is a subclass of Frog. (Inheritance for implementation)

9. Encapsulation Violation

10.

Personal tools