2010 frog design criticisms
From CSSEMediaWiki
(Difference between revisions)
Colin Fagg (Talk | contribs) |
Colin Fagg (Talk | contribs) |
||
| Line 1: | Line 1: | ||
1. Becomes Issue(Egg-Tad-Frog) | 1. Becomes Issue(Egg-Tad-Frog) | ||
| − | 2. Tadpole Tailtype. (Switch stament smell. Change to strategy pattern) | + | 2. Tadpole Tailtype i.e. Swim method. (Switch stament smell. Type Safety issues. Maybe Change to strategy pattern) |
3. Move Interdace should be Method | 3. Move Interdace should be Method | ||
| Line 15: | Line 15: | ||
8. Toad is a subclass of Frog | 8. Toad is a subclass of Frog | ||
| − | 9. | + | 9. Encapsulation Violation |
Revision as of 04:54, 15 July 2010
1. Becomes Issue(Egg-Tad-Frog)
2. Tadpole Tailtype i.e. Swim method. (Switch stament smell. Type Safety issues. Maybe Change to strategy pattern)
3. Move Interdace should be Method
4. saute in wine, export to xml {frog knows about this?}
5. singleton biologist broken.
6. Frogbrain? (why doe it have eggs)
7. Adult frog knows who ate it.
8. Toad is a subclass of Frog
9. Encapsulation Violation
