Talk:Law of Demeter

Revision as of 21:25, 10 September 2008

I started this page with a short description and basic solution...a couple of days ago --Kris 03:34, 1 August 2008 (UTC)

Just added an example --Kris 00:28, 3 August 2008 (UTC)

I spoke to Wal just after the lecture and we were talking about the Law of Demeter, and a situation arose which I have documented below in the UML diagram.

It is possible that in this design you could say...

  car.getEngine().start()

But the Law of Demeter states that generally more than one dot in a line of code is a sign that the law has been broken.

We also talked about another way this design could be approached in order to satisfy the Law of Demeter. The below design would satisfy the law because the start() method in the Car class could look a little something like this...

start()
{
    engine.start();
}

But now I'm a bit confused as to which approach is best? Ken Auer would say that the second approach is messy because it's not using a getter for the engine object. Maybe the getter in the first design could be set as private and the start() method in the Car class could look like this...

  start()
  {
      getEngine().start();
  }

What does everyone else think? --Geoffrey Clark 08:43, 12 August 2008 (UTC)

Well we already talked, but I think the last method is the most extensible. Car can change its implementation of engine (through subclassing or otherwise, and all that needs to be changed is car.start() (and/or car.getEngine() depending). If car.getEngine().start() was being called in several places, this is a good win. --Kris 22:55, 12 August 2008 (UTC)

I added my example to the main page of this topic as Wal recommended it. --Geoffrey Clark 04:02, 14 August 2008 (UTC)

Well sometimes I break this rule for maintainability, ie. avoid duplicating methods, and to avoid Large_class_smell. [[User:Lindsay|Lindsay Kay]