Beware of many accessors
From CSSEMediaWiki
Revision as of 21:34, 7 October 2008 by Elliot Fisher (Talk | contribs)
If there are too many accessors for fields within a class (especially public accessors), it indicates that there are large numbers of requests requiring thoes fields. If a class is designed properly, only a small portion of the class should be usable by the external classes, other parts should be methods which assist the class to implement its behaviour. Too many accessors indicate that related data are not placed together. In addition, too many client requests for field values either means the class is not supporting its own behaviour very well or some unrelated things have been put into the class (which breaks the Single responsibility principle).