Replace Temp with Query

Revision as of 21:18, 14 October 2009

Replace a temp variable with a method call. This makes the variable accessible to other parts of the program. It also allows you to write shorter methods as temp values are only locally available to use you must write all the code related to the temp variable within its scope. I have on many times required a variable outside of its scope and made it global- just straight bad and lazy. -Paul Williams

double basePrice = _quantity * _itemPrice;
if (basePrice > 1000)
    return basePrice * 0.95;
else
    return basePrice * 0.98;

Change to

if (basePrice( ) > 1000)
    return basePrice() * 0.95;
else
    return basePrice( ) * 0.98;
...
double basePrice( ) {
    return _quantity * _itemPrice;
}