Remove assignments to Parameters

From CSSEMediaWiki
Jump to: navigation, search

The code assigns to a parameter.

   int discount (int inputVal, int quantity, int yearToDate) {
       if (inputVal > 50) inputVal -= 2;
       ...
   }

Use a temporary variable instead.

   int discount (int inputVal, int quantity, int yearToDate) {
       int result = inputVal;
       if (inputVal > 50) result -= 2;
       ...
   }

The main reason for removing assignments to parameters is due to lack of clarity and to confusion between pass by value and pass by reference. Java uses pass by value exclusively.

Additional Resources

sourcemaking.com

Personal tools