Remove assignments to Parameters
From CSSEMediaWiki
(Difference between revisions)
(New page: The code assigns to a parameter. int discount (int inputVal, int quantity, int yearToDate) { if (inputVal > 50) inputVal -= 2; ... } Use a temporary variable inst...) |
m |
||
| Line 18: | Line 18: | ||
== Additional Resources == | == Additional Resources == | ||
| − | + | [http://sourcemaking.com/refactoring/remove-assignments-to-parameters sourcemaking.com] | |
| − | + | ||
Revision as of 00:08, 7 August 2009
The code assigns to a parameter.
int discount (int inputVal, int quantity, int yearToDate) {
if (inputVal > 50) inputVal -= 2;
...
}
Use a temporary variable instead.
int discount (int inputVal, int quantity, int yearToDate) {
int result = inputVal;
if (inputVal > 50) result -= 2;
...
}
The main reason for removing assignments to parameters is due to lack of clarity and to confusion between pass by value and pass by reference. Java uses pass by value exclusively.
