Data clumps smell
Brett Ward (Talk | contribs) (Common Refactorings added) |
|||
| Line 16: | Line 16: | ||
[[Category:Code smells]] | [[Category:Code smells]] | ||
| + | |||
| + | == Conflicts == | ||
| + | *[Data class smell] - the grouping of data clumps into a class is considered a smell itself, if such a class does not define useful behaviour. | ||
Revision as of 07:59, 19 October 2010
Data clumps are groups of data items that are related and are always used or passed around together. They are often primitive values. An example of this is a "start" variable and an "end" variable.
Martin Fowler suggests replacing these clumps with a single object. In the example above the start and end could be replaced by a "Range" class. Doing this refactoring decreases the size of parameter lists when the values are passed around. This is one solution to the Long parameter list smell. You can also discover some nice behaviour when you extract the data into an object. For the Range example, you often want to know if a value is within the start and end range, so you could define an "includes" method in the Range class to check for this easily.
Common Refactorings
See also
Conflicts
- [Data class smell] - the grouping of data clumps into a class is considered a smell itself, if such a class does not define useful behaviour.
